World: r3wp
[!REBOL3 Host Kit]
older newer | first last |
Maxim 26-Oct-2010 [457x3] | arg... path= patch. |
in the host-kit/src there is an os folder... that is where all the OS/platform-specific things are supposed to be. | |
once that is mapped all the rest is supposed to work multi-platform. | |
ssolie 26-Oct-2010 [460] | Andreas, sharing a common host-kit might be #ifdef hell though? |
Andreas 26-Oct-2010 [461x2] | Yes, in a few places. |
But that's how it is already anyway. | |
ssolie 26-Oct-2010 [463] | true.. it is fairly isolated so far |
Andreas 26-Oct-2010 [464] | #ifdef where necessary, and separate files in the os/*/ trees where sensible. |
Maxim 26-Oct-2010 [465] | when it gets to complex, its extracted and put into an isolated file, which is how its been evolving so far... quite straightforward. |
Andreas 26-Oct-2010 [466x2] | We just really need to get Carl to the point where the hostkit is kept as a single source base. |
Not one codebase for each platform which then slowly get out of sync. | |
ssolie 26-Oct-2010 [468] | where do commits go then? |
Andreas 26-Oct-2010 [469] | rofl. |
Maxim 26-Oct-2010 [470] | yeah we need to get to the point where Carl doesn't touch the host-kit anymore ;-D |
Andreas 26-Oct-2010 [471] | /dev/null |
ssolie 26-Oct-2010 [472] | lol |
Maxim 26-Oct-2010 [473] | localhost://svn/ |
Andreas 26-Oct-2010 [474] | I maintain a Git mirror of the hostkit sources at http://github.com/rebolsource/r3-hostkit |
ssolie 26-Oct-2010 [475] | is there a standard for EOL? amiga uses LF as most sane OSs :) |
Maxim 26-Oct-2010 [476] | and I'll probably put my CGR package on github too in a short while. |
Andreas 26-Oct-2010 [477x4] | nope, that's one of the main differences between the hostkits :) |
the win32 hostkit has CRLF, the linux hostkit LF | |
eventually we should just decree one and run with it. | |
and given that carl seems to be 90% windows these days, it'll probably be windows line endings. | |
ssolie 26-Oct-2010 [481] | bah :-p |
Andreas 26-Oct-2010 [482x2] | agreed :) |
(note that my git mirror does not contain A109 because it wasn't really released officially, and I wanted to wait if Carl wants to hotfix the compile issue.) | |
ssolie 27-Oct-2010 [484x2] | Why is there a BOOL and a REBOOL ? |
Amiga defines BOOL which is conflicting with R3's BOOL | |
Maxim 27-Oct-2010 [486] | are they using the same typedef? |
ssolie 27-Oct-2010 [487x2] | no, Amiga typedefs to short while REBOL #defines to int |
seems strange to have 2 bool types in REBOL ? | |
Maxim 27-Oct-2010 [489x2] | REBOOL is more compact for smaller structs. |
strange that its trippping you though since its within an #ifndef #ifndef BOOL typedef int BOOL; // (int is used for speed in modern CPUs) #endif | |
ssolie 27-Oct-2010 [491x3] | the precompiler knows nothing of typedefs so when Amiga typedefs BOOL it skips the #ifndef check |
I may have to keep the rebol and amiga stuff completely seperated | |
(different files) | |
Maxim 27-Oct-2010 [494] | I'd just rename the rebol BOOL to some other Identifier,and do a quick recursive file replace... I looked and its not used that much. |
ssolie 27-Oct-2010 [495] | not good for common host-kit later though.. |
Maxim 27-Oct-2010 [496x2] | then give a note to carl so that it gets changed in the next host-kit. cause I don't find it a good practice anyways. strangely, I was wondering if BOOL would cause compiler hickups a few weeks ago. |
guess I was right ;-) | |
ssolie 27-Oct-2010 [498x2] | maybe REBOL should just use the C99 _Bool type instead which is optimized for each platform |
instead of assuming int is best | |
Maxim 27-Oct-2010 [500] | MSVC doesn't support C99. :-( though maybe _Bool is defined anyways. |
ssolie 27-Oct-2010 [501] | lol... silly microsoft.. for windows we can just typedef _Bool until they catch up? |
Maxim 27-Oct-2010 [502x2] | thing is I see that BOOL is used in the host-kit as return values, so expecting the same dll to be compatible with different compilers might be dangerous. |
since we aren't compiling the core ourself. it might be using some different typedef. | |
ssolie 27-Oct-2010 [504] | this is why ISO standarized things over 10 years ago.. ;-) |
Maxim 27-Oct-2010 [505x2] | hehe |
standards? programmers? are you kidding? ;-) | |
older newer | first last |