ftp patch

Tried this on my two servers and (like Brett's) it corrects all my issues. Good job. Are you and Brett going to join / merge efforts on this one now that we have two working models? ;) Regards, Ashley

Good news.

I'm sure we are. From what I've seen so far Romano's work will be the better base to build on. I like what he has done. However it might take RT more time to review it for inclusion in their products because of the literal (not necessary logic) differences. But more comments should alleviate that. In the end I think it is better to have a much stronger result. Regards, Brett.

Great work! I have looked through your code and I have tried it with my server. It would be good to use it as a base to build on. Here's my comments and findings. ---NLST and "Blind" directories Having looked into NLST more I agree with you - let's just leave it out. If someone has a desperate need then maybe their situation will show a solution (custom code perhaps). Also for "blind" directories better to get what we have working and cleaned up and deal with the blind problem later if it arises. --- Parse-files I believe this function should return none! when parsing fails and a block when it succeeds. By returning none! an error can be raised within parse-dir-list. The problem at the moment is if parsing fails, inaccurate results can be returned without the user knowing. I've confirmed this with my dodgy test ftp server by emitting deliberately badly formated data (to simulate an unknown directory listing). ---Data-connect There's two instances of "error? catch". ---Parse-dir-list temp: 'list can be removed by putting the 'list as the parameter directly. Might be nice to make file-list local to the function. ---PWD and CWD PWD does not seem to appear at all in network tracing - my patch showed it coming just after SYST. I think you may have introduced a bug on CWD. I think that the path should not be modified if it beings with a "/". I suggest reverting to the original version of this. ---Unchanged words These appear to be no different to me: list-check list-file-check rmdir-check ---Globals I think parse-dir-list and others can be made local ---"Check you login" bug. This appears in the original scheme and your scheme, but not my scheme. I tried to identify what was going on but so far I have not found the problem. I assume it is to do with connection management and when things are closed. This is the sequence: site: ftp://XXXX:[YYY--codeconscious--com]/ print mold read site ; -> SUCCESS make-dir join site %test-a/test-b/ ; ERROR 550 print mold read site ; SUCCESS probe read join site %test-a/test-b/ ; ERROR 550 print mold read site ; SUCCESS probe read join site %test-a/ ; ERROR 550 print mold read site ; ERROR = Failed login to codeconscious...check your login probe read join site %test-b/ ; ERROR = Failed login to codeconscious...check your login print mold read site ; ERROR = Failed login to codeconscious...check your login A strange thing I noticed looking at the trace for the MAKE-DIR was PORT. I guess I wasn't expecting to see it for make-dir. This was the sequence in the trace for make-dir: USER PASS SYST PORT CWD PORT MKD Maybe some more network logging for the connections will help. Regards, Brett.

my test case is fairly simple: <code> do %ftp-patch.r ;do %ftp-proposed.r sumtree: function [dir [file! url!]] [val] [ val: 0 foreach file read dir [ val: val + either #"/" = last file [sumtree dir/:file][1] ] val ] sites: [ ftp://userid:[password--www--site1--com--au]/public_html/ ftp://userid:[password--www--site2--com]/public_html/ ] foreach site sites [ print reform ["Testing" site] print read join site %test/ ; non-empty dir print read join site %test2/ ; empty dir print sumtree site ] </code> This now fails (more than halfway through?!) in the sumtree function with the following error: ... Net-log: {250 OK. Current directory is /public_html/documents} Net-log: "Type: dir" Net-log: ["TYPE A" "200"] Net-log: "200 TYPE is now ASCII" Net-log: ["LIST" ["150" "125"]] Net-log: "150 Connecting to port 1412" Net-log: ["Closing sub-port" tcp 20 20 1412] Net-log: [none "226"] Net-log: "226-Options: -l " Net-log: "226 5 matches total" URL Parse: userid password www.site.com.au none public_html/images/ none Net-log: ["PWD" "25"] Net-log: {257 "/public_html/documents" is your current location} Net-log: ["Opening" "tcp" "for" "FTP"] Net-log: [none ["220" "230"]] Net-log: ["Opening listen tcp port for FTP"] Net-log: [["PORT" port/locals/active-check] "200"] Net-log: ["PASV" "227"] ** User Error: Server error: tcp connection failed ** Near: foreach file read dir [ val: val + either #"/" = last file [sumtree dir/:file] [1] ]

If you need the full log and / or the log of Brett's run (which works) I can email it to you direct. Regards, Ashley

...

I've reproduced your error with a different sequence - looking into it with Romano. Regards, Brett.