r3wp [groups: 83 posts: 189283]
  • Home
  • Script library
  • AltME Archive
  • Mailing list
  • Articles Index
  • Site search
 

World: r3wp

[Red] Red language group

BrianH
11-Mar-2011
[243]
What they are doing is using the Usenet message format in Google 
Groups, and that means ~78 character lines iirc. That format was 
designed for composing messages in terminals (like in R3 chat) or 
in special editors that use fonts like Courier when composing messages. 
It's surprising that they didn't relax the format a little for groups 
that aren't mirrored on the real Usenet, but when you "Show original" 
(in the "More options" section) the message is formatted for Usenet 
and email.
Andreas
11-Mar-2011
[244x2]
Brian, Google Groups still is a mailing-list tfrontend, so those 
messages actually go out via email.
(Somewhere this sentence misses an "also" ... :)
Steeve
11-Mar-2011
[246]
Question: I created my fork.

And now I created a branch on my computer, but where am I supposed 
to work exactly ? 

I mean, I only see the source files in a sub dir called /red-system
Dockimbel
11-Mar-2011
[247x2]
Your question should be posted in "Source Control" channel.
Maybe you should have look at a Git documentation first?
Steeve
11-Mar-2011
[249x3]
ah, I looked
Trying to push my first modifications currently...
Doc, do you see something ? 
I pulled a request.
Andreas
11-Mar-2011
[252x4]
yep, here it is:
https://github.com/dockimbel/Red/pull/1
why did you comment out the original code, instead of just deleting 
it?
(refering to: https://github.com/SteeveGit/Red/commit/d5f6c9f)
i'd suggest to keep the TBD comments and delete the rest
Steeve
11-Mar-2011
[256]
You mean, you don't want to see the old code as comments ?
Andreas
11-Mar-2011
[257]
Exactly.
Dockimbel
11-Mar-2011
[258x2]
Steeve: yes, got it, looks good to me. I'll pull it in a few minutes. 
Andreas is right, you don't need to comment the old code, just delete 
it (but keep the TBD comments).
Your pull request disappeared, I guess you'll publish a new one.
Steeve
11-Mar-2011
[260x2]
In one minute...
sorry...
Dockimbel
11-Mar-2011
[262]
Oh, my bad, looking in the wrong repo...still need to adjust to the 
DCVS approach.
Andreas
11-Mar-2011
[263x2]
The pull requests will appear in your repo (dockimbel/Red).
Steeve's commits of course go to Steeve's repo :)
Dockimbel
11-Mar-2011
[265]
Sure, it's clear to me now. :-)
Steeve
11-Mar-2011
[266]
I repulled a request.
Dockimbel
11-Mar-2011
[267]
Ok, merging it to my Red repo...
Steeve
11-Mar-2011
[268]
But, instead of seeing 2 commitments , I should have deleted the 
first one.
Don't know how to do that though....
Dockimbel
11-Mar-2011
[269x3]
Done
Steeve: have you tested the changes locally by compiling the hello 
script?
The power-of-2? function is not retro-compatible with the previous 
version.
Steeve
11-Mar-2011
[272]
eh ?
Dockimbel
11-Mar-2011
[273]
Let me test that more closely...
Steeve
11-Mar-2011
[274]
I've not tested with the compiler but the function itself
Dockimbel
11-Mar-2011
[275x2]
The compiler chokes on the new version of this function, but works 
with the old one.
It was missing a to-integer conversion: power-of-2?: func [n [integer!]][if 
zero? n - 1 and n [to integer! log-2 n]]
Steeve
11-Mar-2011
[277x2]
ah, yes sorry
Should have tested with the compiler.
sorry
Dockimbel
11-Mar-2011
[279]
Fixed. Thanks for the nice code reduction ;-)
Steeve
11-Mar-2011
[280x2]
well it should be a little little faster aswell ;-)
I saw some rooms for code factorization also, but you want it as 
fast as it can, I guess
Dockimbel
11-Mar-2011
[282]
For now, it's a prototype code, it doesn't need to be much micro-optimized 
as it will be fully rewritten in a few months using the Red language.
Steeve
11-Mar-2011
[283x2]
I see that you use a lot, nested EITHER structures.
Personnaly I prefer flat CASE structures, more readable.
And i also think CASE could be faster.
Yeah, it's temporary.
Dockimbel
11-Mar-2011
[285]
I guess you're looking at IA32.r/emit-path code?
Steeve
11-Mar-2011
[286]
yes
Dockimbel
11-Mar-2011
[287]
I need to factorize the code first, there's some redundancies, but 
it's also untested code. So, once it will work ok, I'll clean it 
up.
Steeve
11-Mar-2011
[288]
Go Go Gadget
Dockimbel
11-Mar-2011
[289x2]
:-)
Btw, you've opened an issue ticket too...good opportunity for me 
to test github's tickets management options.
Steeve
11-Mar-2011
[291]
Hm... I did nothing though.
Dockimbel
11-Mar-2011
[292]
It seems a ticket is opened for each pull request...